-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 8u131 and new URL scheme #60
base: master
Are you sure you want to change the base?
Conversation
Can we get this merged ASAP please? |
+1 Would really like to not have to tell everyone to |
set_fact: | ||
jdk_version_detail: "{{ java_version }}u{{ java_subversion }}-b11" | ||
jdk_tarball_hash: d54c1d3a095b4ff2b6607d096fa80163 | ||
when: java_version == 8 and java_subversion == 131 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about making these defaults
, so that they can be overridden? That way, users can override when a new version is released.
There's a fork that seems to be maintained and published to Ansible Galaxy, perhaps we should focus our efforts there? https://github.com/srsp/ansible-oracle-java |
Good idea @gjedeer, looks like WilliamYeh hasn't pushed anything publicly since March 4th 2017... |
Seems reasonable to support @srsp 's fork. However, I'll point out that he doesn't appear to have issues enabled for that repo, which is somewhat of a down-side for collaboration. |
@b-long Issues are now enabled. Sorry about that. |
@srsp Cheers! Thanks for doing that :) |
New URL scheme with hash is described in #58